enhance tests (part 1) #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
force-pushed
the
enhance-tests
branch
6 times, most recently
from
eb29e4d to
c914a55
Compare
…y/secondary mantle-controller are created Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
force-pushed
the
enhance-tests
branch
2 times, most recently
from
4d56212 to
7eedfcd
Compare
satoru-takeuchi
requested changes
Jan 6, 2025
test/e2e/multik8s/suite_test.go
Outdated
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
|
|
||
| It("should delete MantleBackup in the primary cluster", func(ctx SpecContext) { |
There was a problem hiding this comment.
Suggested change
| It("should delete MantleBackup in the primary cluster", func(ctx SpecContext) { | |
| It("should delete MantleBackup created by primary mantle from standalone mantle", func(ctx SpecContext) { |
There was a problem hiding this comment.
Fixed in 3cb74fc.
satoru-takeuchi
approved these changes
Jan 7, 2025
…o standalone Signed-off-by: Ryotaro Banno <[email protected]>
… backups in both clusters Signed-off-by: Ryotaro Banno <[email protected]>
…er sync succeeded Signed-off-by: Ryotaro Banno <[email protected]>
…secondary cluster Signed-off-by: Ryotaro Banno <[email protected]>
…primary cluster Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
…ved in secondary cluster Signed-off-by: Ryotaro Banno <[email protected]>
…ved only in the primary cluster Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
force-pushed
the
enhance-tests
branch
from
5779066 to
2f52044
Compare
|
@satoru-takeuchi I squashed my commits. Could you review this again? |
satoru-takeuchi
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.